search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[Share Context Modal Redesign] Refactor `delegatedShareUrlHandler` to handle Promise results #182681

Open rshen91 opened 6 months ago

rshen91 commented 6 months ago

This issue is opened after https://github.com/elastic/kibana/pull/180406 where the link_content is set as the default for the share context modal vs the older implementation of UrlParams in the share plugin.

As a request from @elastic/kibana-visualizations this issue is to track changing delegatedShareUrlHandler in src/plugins/share/public/components/tabs/link/index.tsx to handle Promise results. This was introduced in the share modal redesign.

elasticmachine commented 6 months ago

Pinging @elastic/appex-sharedux (Team:SharedUX)

eokoneyo commented 5 months ago

Hey... following up with the request, do we want to be able to handle promise results here https://github.com/elastic/kibana/pull/180406/files#diff-e4f1bd21624573e91fe1295688d5b674e80f3b421d4e6f2d3e0cf7b4dda8dbacR105 or just support allowing to define delegatedShareUrlHandler as a method that returns a promise?

dej611 commented 5 months ago

Hey... following up with the request, do we want to be able to handle promise results here https://github.com/elastic/kibana/pull/180406/files#diff-e4f1bd21624573e91fe1295688d5b674e80f3b421d4e6f2d3e0cf7b4dda8dbacR105 or just support allowing to define delegatedShareUrlHandler as a method that returns a promise?

That would be great from the Lens prospective as this snippet could be moved within the handler entirely then.