Removes dashboard dependency from maps

stratoula commented 1 week ago

Summary

The maps plugin is the last consumer of the allowByValueEmbeddables. This PR removes it from the plugin.

Note: The remaining part is to remove it from the dashboards plugin but I will leave it to the dashboard team to handle it as removing the dashboard.allowByValueEmbeddables yml setting might be considered a breaking change.

nreese commented 1 week ago

Note: The remaining part is to remove it from the dashboards plugin but I will leave it to the dashboard plugin to handle it as removing the dashboard.allowByValueEmbeddables yml setting might be considered a breaking change.

Thanks, I moved https://github.com/elastic/kibana/issues/137197 to new so it will come up in our next triage session and we can plan for this change

stratoula commented 1 week ago

/ci

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 93bcfc5d1d81b8aca3d7c53c60d8aae14a48f702

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	3.0MB	3.0MB	-89.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`maps`	51.3KB	51.2KB	-107.0B

History

:yellow_heart: Build #208313 was flaky 884f558facbea55d9dc90e3ff4576e1bf464741f
:broken_heart: Build #208216 failed b5174fd3012b0ba6e452d0e111fbacb7c6acfed3
:broken_heart: Build #208209 failed 1ce8fa9a767b53f8b8e82fc167c11a321abb5296

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

elastic / kibana