Closed alvarezmelissa87 closed 4 days ago
Pinging @elastic/ml-ui (:ml)
Testing this I also found an issue when changing the selected job (also happens on main
). I think this occurs when switching from a job with 1 detector to one with multiple detectors and selecting the detector at an index which doesn't exist in the first job. Here I select a job with 2 detectors and pick the second detector.
Looks like buildConfigFromDetector
in chart_config_builder.ts
is called several times, and at one point is passed the config for the previously selected job but the detector index from the new selection:
https://github.com/elastic/kibana/assets/7405507/bad74cb0-bb47-43bc-b7fa-cb495aa149aa
This is ready for another look when you get a chance cc @darnautov, @peteharverson
@elasticmachine merge upstream
@elasticmachine merge upstream
merge conflict between base and head
Fewer modules leads to a faster build time
id | before | after | diff |
---|---|---|---|
ml |
2013 | 2012 | -1 |
Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app
id | before | after | diff |
---|---|---|---|
ml |
4.2MB | 4.2MB | +519.0B |
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
ml |
77.0KB | 77.0KB | -2.0B |
To update your PR or re-run it, just comment with:
@elasticmachine merge upstream
cc @alvarezmelissa87
Summary
Part of https://github.com/elastic/kibana/issues/182042 This PR also fixes the issue in the swimlane embeddable that fails to close the flyout if navigating into the main dashboards page.
Related meta issue: https://github.com/elastic/kibana/issues/181272 Item:
https://github.com/elastic/kibana/issues/181272
Checklist
Delete any items that are not applicable to this PR.