elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.52k stars 8.07k forks source link

[Dashboard management UI][KEYBOARD]: Focus must be returned to the triggering element when modals, menus, dialogs are closed #182764

Open 1Copenut opened 2 months ago

1Copenut commented 2 months ago

Description When modal dialogs, menus, popovers are closed, the triggering element (usually a button) must receive focus again so keyboard and screen reader users do not have to traverse the DOM to get back to their previous location. The Dashboard view has a few cases where it's not managing focus properly. Screenshots attached below.

Steps to reproduce

  1. Log into a QA environment and open a new classic Deployment
  2. Turn on the sample dashboards and navigate to one
  3. Click to Edit dashboard, and try out the panel editing with a keyboard (no mouse)
  4. Verify the screenshots shown below for panel editing and Dashboard menus return focus to the top of the page instead of triggering elements.
Screenshot 2024-05-06 at 6 45 44 PM
Screenshot 2024-05-06 at 6 46 23 PM

Actual Result

Expected Result

Kibana Version: 8.14.0

OS: MacOS

Browser: Chrome latest

Relevant WCAG Criteria:

elasticmachine commented 2 months ago

Pinging @elastic/kibana-accessibility (Project:Accessibility)

elasticmachine commented 2 months ago

Pinging @elastic/kibana-presentation (Team:Presentation)

ThomThomson commented 2 months ago

Noting here that we will be looking into this (specifically returning focus after an inline edit operation) after our embeddable refactor, when we start working on unifying editors & more streamlined inline editing experiences.