[Cloud Security] Disable/Enable rule takes too long

seanrathier commented 1 week ago

Summary

This change resolves the Benchmark Rules page's performance when enabling or disabling rules. Most of the work was converting the change_csp_rule_state to use the ReactQuery useMutation hook. This change introduces optimistic updating of the cached data, while at the same time performing the HTTP request to bulk update to mute or unmute the rules.

Should anything fail with the HTP request, the snapshot of the data taken before the cache was optimistically updated will replace the mutated data.

Other changes:

Removed the refetch call in the rules_table and instead opted to use the invalidateQueries
Removed the await from the original invalidateQueries as these can be executed in the background.
Removed useMemo hook from the table columns because there was no visual difference and it introduces more complexity for the execution.

https://github.com/elastic/kibana/assets/4624273/43a0d7e8-cd20-4cc8-8213-aa600d74efff

Checklisthttps://github.com/elastic/kibana/pull/182768/files

[x] Unit or functional tests were updated or added to match the most common scenarios
[x] Flaky Test Runner was used on any tests changed

For maintainers

[ ] This was checked for breaking API changes and was labeled appropriately

seanrathier commented 1 week ago

/ci

elasticmachine commented 1 week ago

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

seanrathier commented 1 week ago

/ci

kibana-ci commented 2 days ago

:yellow_heart: Build succeeded, but was flaky

Buildkite Build
Commit: 4003b1496901625b988456a7e84ac9cc5d12a450

Failed CI Steps

FTR Configs #59

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	448.5KB	448.7KB	+190.0B

History

:green_heart: Build #209562 succeeded 309b4462ec966e3a4b65a3fc31379b889d639bfb
:broken_heart: Build #209315 failed a63b67904117f2eb1b2e2d7e3ed1e1ac2930759c
:green_heart: Build #209034 succeeded 630c546cb6432a701079e2be486a13ed582a0b3f
:yellow_heart: Build #209001 was flaky 630c546cb6432a701079e2be486a13ed582a0b3f
:green_heart: Build #208809 succeeded 6ada5282704605ea3dd73223c4bf08ec9c7cabac

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

elastic / kibana