elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

Upgrade EUI to v94.3.0 #182822

Closed tkajtoch closed 1 week ago

tkajtoch commented 1 week ago

v94.2.1-backport.0v94.3.0

Questions? Please see our Kibana upgrade FAQ.


v94.3.0

Bug fixes


Most of the code changes you'll see in this PR are caused by the recent EuiFlex changes making it generic. This, unfortunately, is something that styled() doesn't always like. I replaced the failing usages of styled(EuiFlexGroup) and styled(EuiFlexItem) to use component and other native EuiFlex props, resulting in the same output but being better typed.

We plan to add more props to EuiFlex* components giving developers control over properties like flex-grow and flex-shring, and reducing the need for writing any custom CSS when using these components. This should reduce the number of styled() wrappers needed even further

tkajtoch commented 1 week ago

Synthetics tests were also failing on main when tested locally and I can't see a correlation between the update and that test suite failing

elasticmachine commented 1 week ago

Pinging @elastic/eui-team (EUI)

elasticmachine commented 1 week ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine commented 1 week ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

tkajtoch commented 1 week ago

The failing synthetics tests are also failing on main and have been failing since (at least) the synthetics move introduced in https://github.com/elastic/kibana/pull/177464 (failing buildkite job).

tkajtoch commented 1 week ago

@elasticmachine merge upstream

kibana-ci commented 1 week ago

:broken_heart: Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB +139.0B
observability 286.2KB 286.0KB -164.0B
securitySolution 15.1MB 15.1MB -909.0B
synthetics 1.0MB 1.0MB -5.0B
total -939.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 253.9KB 254.0KB +71.0B
kbnUiSharedDeps-npmDll 6.3MB 6.3MB +1.8KB
kbnUiSharedDeps-srcJs 3.1MB 3.1MB -1.0B
total +1.9KB

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @tkajtoch