[Security Solution][Timeline] - fix ESQL tab full screen showing unwanted UI elements

PhilippeOberti commented 1 week ago

Summary

This PR fixes a small issue when going to full screen mode on the new ES|QL tab.

The kbn-unified-data-table forces to unset z-index values (see here) but this is not applied to EUI portals which Timeline is. The small change added in this PR focuses on adding this back to the dscPageBody class which is in our case is within the Timeline ES|QL tab.

Before fix

https://github.com/elastic/kibana/assets/17276605/a0d3fb52-8982-48ca-8a43-ab4406cdcf1f

After fix

https://github.com/elastic/kibana/assets/17276605/a16c1d2b-0c79-48df-a530-f1be0afb6274

I also verified that this didn't break the Discover page in Security Solution running in Serverless

https://github.com/elastic/kibana/assets/17276605/dfd850c3-faf5-4998-93c3-8fc121f46fff

https://github.com/elastic/kibana/issues/182812

elasticmachine commented 1 week ago

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 19415f8d77e6c9e23ee483e58f20d3a3b9285ad7

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	13.7MB	13.7MB	+71.0B

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibanamachine commented 1 week ago

💚 All backports created successfully

Status	Branch	Result
✅	8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

elastic / kibana