elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

[Lens] Ignores title when using on-the-fly popover #182896

Closed nickofthyme closed 1 week ago

nickofthyme commented 1 week ago

When using Lens on-the-fly popover, it can sometimes override/ignore the title property.

The offending code is line 233 below, that overrides the title to a presumptive default value of visualization.activeId.

https://github.com/elastic/kibana/blob/64a4c6dfaa3d174ffc2ab7120fbdf8bb0c372b2b/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx#L224-L234

Steps to reproduce

Now the name is changed to InsXY:

Screenshot 2024-05-07 at 21 20 11
elasticmachine commented 1 week ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

markov00 commented 1 week ago

This is actually way worse than it seems. It overrides the visualization title in the Visualization Library on every inline-edited visualization...

https://github.com/elastic/kibana/assets/1421091/3dc8924f-24f8-4ef6-b816-07fad6557031