search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

Add e2e for Attack discovery #182918

Open patrykkopycinski opened 1 week ago

patrykkopycinski commented 1 week ago

Summary

Adds e2e tests for Attack discovery. It takes list of preconfigured connectors from ./config/kibana.dev.yml and for each of them is generating Attack discovery and checks if the output is correct (currently just checking if the host provider doesn't contain {, as it was common issue with one of the connectors)

To test in open mode run:

yarn --cwd x-pack/test/security_solution_cypress cypress:open:ess --spec cypress/e2e/ai_assistant/attack_discovery.cy.ts

To test in run mode:

yarn --cwd x-pack/test/security_solution_cypress cypress:ai_assistant:run:ess --headed

To load Attack discovery data to the existing instance:

yarn --cwd x-pack/plugins/security_solution/scripts/load_attack_discovery_data.js
patrykkopycinski commented 1 week ago

/ci

patrykkopycinski commented 1 week ago

/ci

patrykkopycinski commented 1 week ago

/ci

patrykkopycinski commented 1 week ago

/ci

patrykkopycinski commented 1 week ago

/ci

patrykkopycinski commented 5 days ago

/ci

patrykkopycinski commented 5 days ago

/ci

patrykkopycinski commented 4 days ago

/ci

patrykkopycinski commented 4 days ago

/ci

kibana-ci commented 2 days ago

:broken_heart: Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

PhilippeOberti commented 2 days ago

@patrykkopycinski looking at the code owners (running node ./code-owners.js 182918 in the kibana-operations repo) I see that a lot of the files in this x-pack/test/security_solution_cypress/cypress/fixtures/assistant/attack_discovery/ folder are owned by multiple teams. Maybe it would be a good idea to be a bit more granular here?