[Fleet] add validation to dataset field in input packages to disallow special characters

juliaElastic commented 1 week ago

Summary

Closes https://github.com/elastic/kibana/issues/181044

Added validation to allow only valid index names as dataset name in input packages. Allowing lowercase letters, numbers, dot and underscore (except in the beginning).

To verify:

add Custom Logs integration
modfiy dataset to add invalid characters e.g. *
verify that the field shows a validation error
verify that the save button is disabled
verify that valid dataset names can be used

Checklist

Delete any items that are not applicable to this PR.

[x] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
[x] Unit or functional tests were updated or added to match the most common scenarios

apmmachine commented 1 week ago

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!)

juliaElastic commented 1 week ago

/ci

juliaElastic commented 1 week ago

/ci

elasticmachine commented 1 week ago

Pinging @elastic/fleet (Team:Fleet)

juliaElastic commented 5 days ago

Do you think that this test could be added to the functional tests for this endpoint?

Added an assert on the error message in the existing input package policy API test.

kibana-ci commented 5 days ago

:green_heart: Build Succeeded

Buildkite Build
Commit: 7a79034cf433d6230f2fcd670993de343a457ca2

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1181	1184	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.3MB	1.3MB	+537.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	163.5KB	164.1KB	+645.0B

Unknown metric groups

#### API count | id | [before](https://github.com/elastic/kibana/commit/62d580c11e16f0e094414d8f9cca44ce642bcbfd) | [after](https://github.com/elastic/kibana/commit/7a79034cf433d6230f2fcd670993de343a457ca2) | diff | | --- | --- | --- | --- | | `fleet` | 1302 | 1305 | +3 |

History

:broken_heart: Build #209480 failed 29e660aeaad4db172030eea10c34cc9eaa6ea3ff
:broken_heart: Build #209428 failed c5d402dcf19878fede12c2a7487ac8448b76a930
:broken_heart: Build #209389 failed ae7e21f9631712a2ffa6d084c9056a0547695c16
:broken_heart: Build #209388 failed ae7e21f9631712a2ffa6d084c9056a0547695c16
:green_heart: Build #209127 succeeded 686d42b6b6f5eeeeb5bc001847311bf12880b4c1

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @juliaElastic

kibanamachine commented 5 days ago

💚 All backports created successfully

Status	Branch	Result
✅	8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

elastic / kibana