search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

[Chore][Perf] Remove temp allocation from tabifyAggs #182959

Closed thomasneirynck closed 1 week ago

thomasneirynck commented 1 week ago

Summary

Removes temporary allocation from tabifyAggResponse.

We saw some encouraging performance metrics after the removal of temporary allocation from tabifyDocs https://github.com/elastic/kibana/pull/180647. This PR introduces similar improvements for the tabify-function for aggregation responses.

For maintainers

thomasneirynck commented 1 week ago

/ci

thomasneirynck commented 1 week ago

/ci

thomasneirynck commented 1 week ago

/ci

thomasneirynck commented 1 week ago

/ci

thomasneirynck commented 1 week ago

/ci

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 418.4KB 418.7KB +247.0B

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

drewdaemon commented 1 week ago

Will the performance journeys be precise enough to detect a performance regression in a piece of code like this? Or, does it make sense to add some micro-benchmark tests? No opinion, just asking the question.

thomasneirynck commented 1 week ago

@drewdaemon yes, our current journeys which are run in CI are reliable to enough to track these changes. See https://github.com/elastic/kibana/pull/180647#issuecomment-2104943230 for a previous example.