elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

[Security Solution][Timeline] - fix host and user details flyout not using the correct time for requests when open from Timeline #182968

Closed PhilippeOberti closed 1 week ago

PhilippeOberti commented 1 week ago

Summary

This PR fixes a bug in the user and host detail flyouts (the new ones using the expandable flyout framework). When those flyouts are open from Timeline, the request made to query their data is using the from and to values from the global query, meaning the date interval selected in the alerts page. They should be instead using the date interval from Timeline.

Before fix

https://github.com/elastic/kibana/assets/17276605/84685de8-402d-4dc9-85e9-3e78f50e520f

After fix

https://github.com/elastic/kibana/assets/17276605/ad365303-f0a9-4a90-9e46-8bd742df8db6

https://github.com/elastic/kibana/issues/182967

Notes

I did not add any unit tests for this, as the cutoff for the last BC is happening very soon, and also because no tests existed for these 2 hooks. Let me know if that is ok with you for now @machadoum

elasticmachine commented 1 week ago

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

elasticmachine commented 1 week ago

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

kibana-ci commented 1 week ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.3MB 15.3MB +340.0B

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibanamachine commented 1 week ago

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation