search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

[Security Solution] [Attack discovery] Removes the Attack discovery feature flag #182975

Closed andrew-goldstein closed 1 week ago

andrew-goldstein commented 1 week ago

[Security Solution] [Attack discovery] Removes the Attack discovery feature flag

Summary

This PR removes the feature flag required to enable the Attack discovery feature.

It (always) enables the Attack discovery feature in both self managed and serverless deployments.

Desk testing

  1. REMOVE the attackDiscoveryEnabled feature flag if it was previously enabled in kibana.dev.yml:
# xpack.securitySolution.enableExperimental: ['attackDiscoveryEnabled']

  1. Restart Kibana

  2. Navigate to Security > Attack discovery

Expected results

self_managed

Above: Attack discovery in self managed

attack_discovery_serverless

Above: Attack discovery in serverless

elasticmachine commented 1 week ago

Pinging @elastic/security-solution (Team: SecuritySolution)

stephmilovic commented 1 week ago

@elasticmachine merge upstream

andrew-goldstein commented 1 week ago

/CI

andrew-goldstein commented 1 week ago

@elasticmachine merge upstream

andrew-goldstein commented 1 week ago

@elasticmachine merge upstream

andrew-goldstein commented 1 week ago

@elasticmachine merge upstream

andrew-goldstein commented 1 week ago

@elasticmachine merge upstream

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.3MB 15.3MB -62.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 83.7KB 83.6KB -74.0B

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @andrew-goldstein

kibanamachine commented 1 week ago

💔 All backports failed

Status Branch Result
❌ 8.14 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.14:
- [ML] Refactors Field statistics table from an embeddable to a registered React component (#181502)
- [Security solution] Attack discovery tour (#182605)
- github-issue: remove PR owner from the GitHub issue content (#182954)
- [Search] Updated Notion native config to correct one (#182920)
- [ML] Enable transform health rule API tests (#182560)

Manual backport

To create the backport manually run:

node scripts/backport --pr 182975

Questions ?

Please refer to the Backport tool documentation

andrew-goldstein commented 1 week ago

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation