elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

Focus to anchor element after closing share modal #182985

Closed rshen91 closed 1 week ago

rshen91 commented 1 week ago

Summary

Closes https://github.com/elastic/kibana/issues/178872

Setting up a setTimeout after the onClose for focus to be returned to the anchorElement.

rshen91 commented 1 week ago

/ci

kibana-ci commented 1 week ago

:broken_heart: Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1415 1413 -2
reporting 120 117 -3
share 94 92 -2
total -7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/reporting-public 104 107 +3
share 77 59 -18
total -15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +95.0B
dashboard 406.5KB 406.7KB +116.0B
discover 638.3KB 638.3KB +79.0B
lens 1.4MB 1.4MB -1.2KB
reporting 68.6KB 60.9KB -7.7KB
share 3.6KB 4.2KB +581.0B
visualizations 285.6KB 285.7KB +125.0B
total -7.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
share 11 12 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 50.0KB 49.3KB -705.0B
reporting 56.0KB 52.8KB -3.2KB
share 71.1KB 55.5KB -15.6KB
total -19.5KB
Unknown metric groups #### API count | id | [before](https://github.com/elastic/kibana/commit/099c909abc7a24ecefee93651fd3e245d13b279a) | [after](https://github.com/elastic/kibana/commit/fda6c10d658b5ba296d6f8526a7efa5dbebe8c9a) | diff | | --- | --- | --- | --- | | `@kbn/reporting-public` | 110 | 113 | +3 | | `share` | 136 | 120 | -16 | | total | | | -13 | #### async chunk count | id | [before](https://github.com/elastic/kibana/commit/099c909abc7a24ecefee93651fd3e245d13b279a) | [after](https://github.com/elastic/kibana/commit/fda6c10d658b5ba296d6f8526a7efa5dbebe8c9a) | diff | | --- | --- | --- | --- | | `lens` | 24 | 23 | -1 | | `reporting` | 4 | 3 | -1 | | total | | | -2 | #### ESLint disabled line counts | id | [before](https://github.com/elastic/kibana/commit/099c909abc7a24ecefee93651fd3e245d13b279a) | [after](https://github.com/elastic/kibana/commit/fda6c10d658b5ba296d6f8526a7efa5dbebe8c9a) | diff | | --- | --- | --- | --- | | `@kbn/reporting-public` | 2 | 3 | +1 | #### References to deprecated APIs | id | [before](https://github.com/elastic/kibana/commit/099c909abc7a24ecefee93651fd3e245d13b279a) | [after](https://github.com/elastic/kibana/commit/fda6c10d658b5ba296d6f8526a7efa5dbebe8c9a) | diff | | --- | --- | --- | --- | | `@kbn/reporting-public` | 0 | 2 | +2 | | `discover` | 15 | 16 | +1 | | total | | | +3 | #### Total ESLint disabled count | id | [before](https://github.com/elastic/kibana/commit/099c909abc7a24ecefee93651fd3e245d13b279a) | [after](https://github.com/elastic/kibana/commit/fda6c10d658b5ba296d6f8526a7efa5dbebe8c9a) | diff | | --- | --- | --- | --- | | `@kbn/reporting-public` | 2 | 3 | +1 |

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @rshen91

rshen91 commented 1 week ago

closing - consolidating fix into https://github.com/elastic/kibana/pull/180406