elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.35k stars 7.98k forks source link

Fix `reset` UX for panel `title` and `description` #182986

Closed nickofthyme closed 5 days ago

nickofthyme commented 1 week ago

Summary

This PR proposes updates to the panel title flyout behavior to be more strict about changes to the title, including...

https://github.com/elastic/kibana/assets/19007109/4ee2c045-bc07-4a7e-bff1-636bb60af08e

Checklist

kibana-ci commented 5 days ago

:green_heart: Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/presentation-publishing 161 163 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 493.1KB 493.1KB +23.0B
ml 4.2MB 4.2MB +23.0B
total +46.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboardEnhanced 17.7KB 17.7KB +29.0B
presentationPanel 43.2KB 43.5KB +260.0B
savedObjects 25.3KB 25.3KB +7.0B
urlDrilldown 16.4KB 16.5KB +23.0B
total +319.0B
Unknown metric groups #### API count | id | [before](https://github.com/elastic/kibana/commit/84777406db7e030b9a571788a5c02ccdffc7ffe1) | [after](https://github.com/elastic/kibana/commit/ad8e5db0a8c6671193eba6357583db49c0d0795f) | diff | | --- | --- | --- | --- | | `@kbn/presentation-publishing` | 192 | 194 | +2 |

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream