[ES|QL] remove quoted index name support

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.35k stars 7.98k forks source link

Closed drewdaemon closed 1 week ago

drewdaemon commented 1 week ago

Removes support for quoted index names.

Valid: from my_index

Invalid from "my_index"

drewdaemon commented 1 week ago

/ci

drewdaemon commented 1 week ago

When ANTLR parses from with the the new grammar I’m getting <missing null> as the text of the source node when I used to see ''

drewdaemon commented 1 week ago

/ci

elasticmachine commented 1 week ago

Pinging @elastic/kibana-esql (Team:ESQL)

drewdaemon commented 1 week ago

/ci

drewdaemon commented 1 week ago

The FTR failure is because it's testing against an out-of-date Elasticsearch snapshot that doesn't have https://github.com/elastic/elasticsearch/pull/108431 in it 🙄

kibana-ci commented 1 week ago

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-srcJs`	3.1MB	3.1MB	-308.0B

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibanamachine commented 1 week ago

Status	Branch	Result
❌	8.14	Backport failed because of merge conflicts

To create the backport manually run:

node scripts/backport --pr 182994

drewdaemon commented 1 week ago

Status	Branch	Result
✅	8.14

Note: Successful backport PRs will be merged automatically after passing CI.