Open vitaliidm opened 2 months ago
Pinging @elastic/security-solution (Team: SecuritySolution)
Pinging @elastic/security-detection-engine (Team:Detection Engine)
Hey @banderror ! Would it be ok to assign this one to Rules Management to look into?
@yctercero Of course, it's the feature we added so we'll address the performance concerns as well. Thank you @vitaliidm!
Pinging @elastic/security-detections-response (Team:Detections and Resp)
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)
Epics: https://github.com/elastic/security-team/issues/1974 (internal), https://github.com/elastic/kibana/issues/174168
Summary
Describe the bug: Large number of related integrations can cause significant performance impact on rule creation/edit form.
Steps to reproduce:
Current behavior: Each added item to related integrations contribute to the total time of form re-rendering. Component re-renders on any change in form. So, even typing query, that does not effect state of related integrations, causes this component to re-render. Each added item, adds approx. 1ms in rendering time. For 8 items it takes 8ms, out of 30ms of total form re-render time.
Expected behavior: Component should not re-render when thee are no changes in form that affect it. Similar issue was discovered for required fields and handled in relevant PR
Screenshots (if relevant):