search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.39k stars 8k forks source link

[Infra] Use asset details flyout overview and metadata for containers #183767

Closed jennypavlova closed 1 week ago

jennypavlova commented 2 weeks ago

Closes #183727

Summary

This PR adds asset details flyout to the inventory containers view. The feature flag observability:enableInfrastructureContainerAssetView should be enabled to see it. To handle the asset type switching in the asset details flyout this PR adds asset type to the assetDetailsFlyout URL param

Before: image

After:

Testing

https://github.com/elastic/kibana/assets/14139027/5ba578e6-6cdd-4561-a1f6-27ff4962ef6f

apmmachine commented 2 weeks ago

:robot: GitHub comments

Expand to view the GitHub comments

Just comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine commented 2 weeks ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

kibana-ci commented 1 week ago

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.5MB 1.5MB +681.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5410 +5410
total size - 8.8MB +8.8MB

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @jennypavlova

jennypavlova commented 1 week ago

@MiriamAparicio Thank you for reviewing the PR!

I'm wondering if there are tests for the flyout that we need to add or modify for the container

Good point, I am afraid we don't have tests for the container flyout. I will add a task for it and start adding some after we merge this PR. Edit