elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.71k stars 8.13k forks source link

Skipped test: x-pack/test/security_solution_cypress/cypress/e2e/explore/users/users_tabs.cy.ts - it renders users risk tab #184201

Open MadameSheema opened 3 months ago

MadameSheema commented 3 months ago

The test x-pack/test/security_solution_cypress/cypress/e2e/explore/users/users_tabs.cy.ts - it renders users risk tab has been skipped from serverless executions.

We are moving on serverless from the admin user as a default role, to the platform_engineer user, which has access just to the security solution default indexes.

This test relies on the risk_users archive, which is using the ml_user_risk_score_latest_default index, as the new user does not have access to it the test is failing.

These are the things that might be discussed:

  1. Should this test be moved to Entity Analytics?
  2. Do we really need to test this behaviour on Serverless when the mentioned index is not available in serverless environments for security projects?
elasticmachine commented 3 months ago

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

elasticmachine commented 3 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

jaredburgettelastic commented 3 months ago

Should this test be moved to Entity Analytics?

Great question. The test itself is very simple, it just looks to see if the tab loads, without asserting any of the contents of the tab.

   it(`renders users risk tab`, () => {
      waitForTabToBeLoaded(RISK_SCORE_TAB);

      cy.get(RISK_SCORE_TAB_CONTENT).should('exist');
    });

Ownership gets fuzzy because:

Co-ownership sounds like the right approach to me. I don't think we should move that one test to another file solely owned by EA because of the reasons mentioned above. @asnehalb any thoughts?

Do we really need to test this behaviour on Serverless when the mentioned index is not available in serverless environments for security projects?

I agree that we don't need this test as-is in Serverless, and I believe we should instead test for the "new" risk scores instead of the legacy. Right now, I think @MadameSheema can skip that test for Serverless, and in the short-term we can look into whether there is a different esArchiverLoad we can use that loads new scores instead of legacy.