search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.12k forks source link

[Alert flyout] Improve threshold and observed value for multiple conditions #184328

Open maryam-saeidi opened 3 months ago

maryam-saeidi commented 3 months ago

🍒 Summary

As you see below, in the case of multiple conditions, we show a warning that gives the impression that it can be clicked and some information is missing.

Based on @maciejforcone 's feedback, we would like to re-arrange this information and show the threshold and observed value side by side as shown below: (slack)

Questions

  1. Do we use the same design for one condition? (Including adding condition1?) A: We will not show the condition in part at the start for one condition. We can consider adding it in the end or improving it in a follow-up step.
elasticmachine commented 3 months ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

maryam-saeidi commented 2 months ago

@maciejforcone Do you have a design for when we only have one condition?

Does it make sense to show only condition without any number, so we still have a tooltip in that scenario?

maciejforcone commented 2 months ago

@maciejforcone Do you have a design for when we only have one condition?

Does it make sense to show only condition without any number, so we still have a tooltip in that scenario?

It will look a bit weird for a single condition. Maybe we can show the text "view condition" after the observed/threshold information? so it'll be "120ms (20% above the threshold of 100ms) view condition" and then for multiple it would be "120ms (20% above the threshold of 100ms) view condition 1" and below "120ms (20% above the threshold of 100ms) view condition 2", wdyt?

maryam-saeidi commented 2 months ago

@maciejforcone I liked the design that you shared with Condition 1 at the start better.

Maybe we can either not show condition when we have only one (which we will miss the definition of condition for this case) or use view condition as you mentioned (although having information on both sides of parentheses seems a bit out of place IMO). But I am fine with either, it would be great if we could see it in the flyout similar to this design that you shared:

maryam-saeidi commented 2 months ago

@benakansara @fkanout regarding above comments, I see Maciej mentioned in Slack that we only remove the condition for when we have only one. Any objection, or shall I update this ticket and move it to ready?

Update: I double-checked the Slack message, and it seems Faisal suggested this, so @benakansara, if you are OK, I will update the ticket accordingly.

benakansara commented 2 months ago

I like the idea of showing rule condition on hover/click. If we remove it for single condition scenario which might be most used one, users don't have access to this information in flyout whereas for multiple conditions it will be available.

Regarding whether to show "View condition" link at start or end, similar to what Mary said, I also liked showing the links at start. But between showing at end or not showing at all for single condition, I think end is better 😄

As discussed with @maryam-saeidi on slack, I am fine with moving ticket to ready to enhance multiple conditions UI which is more confusing at the moment.