search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.76k stars 8.17k forks source link

[Console Monaco migration] Resize the editor on window resize #184352

Closed yuliacech closed 2 months ago

yuliacech commented 4 months ago

The Ace editor keeps the split between editor and output panel in relation to each other when the window is resized. The Monaco editor doesn't react to the window resize in the same manner. See screen recording below

Ace

https://github.com/elastic/kibana/assets/6585477/1bc41966-1115-4ae8-8b69-c31c81c3e3b5

Monaco

https://github.com/elastic/kibana/assets/6585477/7a2376a4-a22f-4ed2-bb34-68851bfe84ff

elasticmachine commented 4 months ago

Pinging @elastic/kibana-management (Team:Kibana Management)

sabarasaba commented 2 months ago

I just gave it a go locally, and seems the aspect ratio is maintained although it has a small animation as the text wrapping is happening:

https://github.com/user-attachments/assets/83d2ac23-50f0-44d0-8613-deb02a2af7d5

yuliacech commented 2 months ago

Thanks a lot for checking, @sabarasaba! This issue is not reproducible anymore, closing