search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.24k forks source link

[Security Solution] Investigate improvements to `kbn-openapi-bundler` e2e tests #184930

Open maximpn opened 5 months ago

maximpn commented 5 months ago

Epic: https://github.com/elastic/security-team/issues/9401 (internal)

Summary

kbn-openapi-bundler's e2e tests verify bundler's behavior in different scenarios by passing a set of source OpenAPI specs and verifying the output bundle or its parts. The current implementation abstracts on the details and forces to have specs in the tests. On the other hand it's not always convenient to define specs in TS files and repeat irrelevant specs parts.

The task is to investigate possible improvements which will simplify kbn-openapi-bundler's e2e tests.

Details

While reviewing https://github.com/elastic/kibana/pull/184348 @banderror highlighted that DX around testing of kbn-openapi-bundler's package is quite obscure (comment).

After discussion we agreed that there are ways to improve e2e tests readability and clearness.

elasticmachine commented 5 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 5 months ago

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine commented 5 months ago

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)