search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.47k stars 8.04k forks source link

[ResponseOps][Task Manager][mget Claimer] finish jest, functional, integration tests #184942

Open pmuellr opened 3 weeks ago

pmuellr commented 3 weeks ago

In PR implement task claiming strategy mget #180485 we implemented an alternative task claiming strategy, but it has the following problem:

The jest and function tests are incomplete.

The jest tests do not test all the conditions of the default claimer, which they should.

Some of the function tests added in #180485 were skipped as they were flaky or always failing - those obviously need to be fixed. The functional tests that are there were copied from the existing task manager tests in https://github.com/elastic/kibana/tree/main/x-pack/test/plugin_api_integration/test_suites/task_manager - we should see if there are other function tests we can copy.

We should also see if we can just reuse the existing function tests drectly, instead of copying them. We'll still need a separate config, but maybe we can at least remove the copies of the test modules.

We should also see if we can build a simple integration test that launches multiple Kibanas, and ensures the claimers are working as expected (unclear what that means). We should actually try to make this test work with both claimers!

elasticmachine commented 3 weeks ago

Pinging @elastic/response-ops (Team:ResponseOps)