search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.24k forks source link

[Observability] Cases page are not expanded to take the whole height #185673

Open cnasikas opened 5 months ago

cnasikas commented 5 months ago

The pages in the Cases app when viewed in o11y do not take the whole height of the window. It seems like an issue with the o11y code because the stack and security solution are working as expected.

O11y

Screenshot 2024-06-07 at 5 19 10 PM

Security

Screenshot 2024-06-07 at 5 21 18 PM

Stack management

Screenshot 2024-06-07 at 5 19 26 PM

elasticmachine commented 5 months ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

cnasikas commented 5 months ago

I did a quick investigation and noticed a span HTML element surrounding the page causes the page not to go full height. It seems that removing the KibanaThemeProvider in x-pack/plugins/observability_solution/observability/public/application/index.tsx works. Not sure of the implications of removing the KibanaThemeProvider. The KibanaRenderContextProvider on top should take care of everything but I think you need to migrate from styled-components to emotion. cc @tsullivan

Screenshot 2024-06-29 at 2 31 30 PM
tsullivan commented 5 months ago

I did a quick investigation and noticed a span HTML element surrounding the page causes the page not to go full height. It seems that removing the KibanaThemeProvider in x-pack/plugins/observability_solution/observability/public/application/index.tsx works. Not sure of the implications of removing the KibanaThemeProvider. The KibanaRenderContextProvider on top should take care of everything but I think you need to migrate from styled-components to emotion. cc @tsullivan

I don't know how styled-components and emotion intersect here, sorry. But migrating to emotion is recommended.

With my limited experience, I believe KibanaThemeProvider can be safely replaced with KibanaRenderContextProvider except when you need to use the modify prop of KibanaThemeProvider. However, even that might not be the case any longer: https://github.com/elastic/kibana/pull/186055. I would check with @clintandrewhall and/or the EUI folks.