elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.48k stars 8.04k forks source link

[Synthetics] Lightweight project monitors should support URL strings containing commas #186093

Open justinkambic opened 3 weeks ago

justinkambic commented 3 weeks ago

Update: URLs with commas will work, but they must be specified in a list in the YAML definition. For example:

heartbeat.monitors:
- type: http
  name: Todos Lightweight
  id: todos-lightweight
  enabled: true
  # specify a list of URLs with one entry
  urls:
    - "https://elastic.github.io/synthetics-demo/?demo=123,345"
  schedule: '@every 10s'
  timeout: 16s

The original design goal of this behavior was to accept and parse multiple URLs from a comma-delimited list in the case of a string value, and this check is not performed when an array is received. This is a workaround, but it makes for a bad experience and I don't think we should expect users to figure this out on their own especially if it's not noted in the docs.

Describe the feature:

When I attempt to push a Synthetics project, if my lightweight HTTP checks have any URLs containing the , character, my push for those monitors is rejected.

Describe a specific use case for the feature:

Some URLS contain commas. It isn't ideal but it's a reality of the web that it happens. AFAIK there is no technical reason not to support this.

Creation of this ticket was driven by https://github.com/elastic/sdh-synthetics/issues/97.

elasticmachine commented 3 weeks ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine commented 1 day ago

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)