[Lens][ES|QL] Re-running the query should keep the selected chart type if possible

stratoula commented 3 months ago

Describe the feature:

Right now, every time a user submits a query in the editor, the Lens suggestions api runs and suggests a new chart. This results in changed made in the visualization level to be lost.

It would be cool if we could at least prioritize the activeVisualization chart Type. This is very easy as the suggestions api can already do it (with the preferredChartType property). The visualization state is lost though (colors, legend settings etc).

We need to:

ask from the suggestions api to prirotize the current visualizationType
check if the query hasn't introduced major changes in the columns (check that the used columns in the datasourceState are being returned from the new query and in that case not change the chart.
if the columns are different we can just keep the visualization type and render the attributes returned from the suggestions api.

elasticmachine commented 3 months ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

elasticmachine commented 3 months ago

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula commented 3 months ago

As a feature related to ES|QL and of a mid - high impact I am adding this on the ES|QL project team roadmap. Related to https://github.com/elastic/kibana/issues/184631

elastic / kibana

[Lens][ES|QL] Re-running the query should keep the selected chart type if possible #186366