elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.76k stars 8.17k forks source link

[OneDiscover] Custom Cell Popover for host.name in logs context #186816

Open kertal opened 3 months ago

kertal commented 3 months ago

📓 Summary:

In the logs context, the popover for the host.name field should provide detailed insights into the metrics of the specified hostname. It should display charts using basic area chart for available metrics, such as:

The display of these metrics will depend on the availability of corresponding data.

Bildschirmfoto 2024-06-24 um 14 16 57

🚧 Needs refinement 🚧

✔️Acceptance criteria:

elasticmachine commented 3 months ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

gbamparop commented 2 months ago

@roshan-elastic the extension point for a custom cell popover is now ready. We could use this to surface additional information about entities such as service or host metrics as described above. Is there any work planned to implement these APIs? cc @tommyers-elastic

roshan-elastic commented 2 months ago

Wow- looks great @gbamparop!

@chrisdistasio / @smith @andrewvc / @tommyers-elastic - Should these metrics be pulled from EEM?

I feel like they should be as this functionality doesn't seem to require any complex aggregations that need to allow correlation etc.

WDYT?

smith commented 2 months ago

Should these metrics be pulled from EEM?

It looks like it's probably using the same metrics and queries as the hosts UI.

This is a contextual view for a host entity, so it probably should be located near other host entity views.

Is there a plan for the Data Discovery team to be creating and maintaining entity views? If so we should make sure we're keeping the UX and data requirements in sync.

kertal commented 2 months ago

Is there a plan for the Data Discovery team to be creating and maintaining entity views? If so we should make sure we're keeping the UX and data requirements in sync.

No, there's no plan for that, we rely on o11y folks to bring this nice feature to life. The API is there, so ideally this issue should be refined to become actionable on o11y side (we can also replace it with another issue of course since we won't drive the implementation + maintenance)

gbamparop commented 2 months ago

@smith This is an example of how we can display such information in Discover, it doesn't necessarily have to be in the cell popover, it could be added to the log details flyout or anywhere else it makes sense. It'll be good to figure out what the dependencies are if this is something that we should prioritise cc @alex-fedotyev

smith commented 2 months ago

@gbamparop thanks!

@kertal thanks for clarifying. Happy to help make this happen.