elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.77k stars 8.17k forks source link

Developer Console Review #187168

Closed julianrosado closed 1 month ago

julianrosado commented 3 months ago

Context

The AppEx team has taken the existing developer console and updated it to use the more extensible Monaco editor. Since it is easier to change the UI in this editor, and with the increased usage of the dev console in it's new persistent state (the dev console editor flies up from the bottom of any Search page) we thought it'd be a good opportunity to refresh the UI. That's where I came in! Since this feature will be used in multiple spaces (across Search between the full page and persistent console) and across products, I felt it was necessary to get ahead of any a11y issues by flagging this redesign early.

Latest - As of June 28, 2024

Figma board Figma prototype

Request

Just a general request for any obvious a11y issues or suggestions on how to avoid any in the future. It is likely the AppEx team will start developing this before the a11y review is complete, so leaving suggestions in the Figma board that I can filter into issues for them would probably be the most efficient process but I am not married to that flow if you have a better idea.

As always you know where to find me, and I am happy to walk you through or answer any questions. 💪 Pre-thanks!

1Copenut commented 3 months ago

@julianrosado I added my first pass comments in the Figma file. There's a lot of really cool stuff going on here!

Most of my comments are based around annotations for devs (accessible labels, focus management, etc.) and user experience for managing announcements and updates when user a screen reader. Let me know if anything seems wildly off base or you want to discuss any comments further.

elasticmachine commented 2 months ago

Pinging @elastic/kibana-management (Team:Kibana Management)

alisonelizabeth commented 1 month ago

We will track this work via a different issue - thanks!