search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

Improve dashboard panel preview experience #187864

Open eokoneyo opened 2 months ago

eokoneyo commented 2 months ago

Blocked by #151233.

Kibana version: main

Describe the bug: In dashboard panels where the preview exists (ES|QL for example), the user can perform the panel actions while it is still in the create panel flow which in turn could results in some unexpected behaviour. For Instance; one can delete the panel being added, which leaves the user in an orphaned configuration flyout with no panel on which the configuration is being made to.

Steps to reproduce:

  1. Navigate to dashboard app, click the add panel button, select for example the ES|QL visualisation option.
  2. On being presented the configuration flow for this panel, click the panel action hamburger menu, and delete the panel that was just added
  3. One would be left with an orphaned configuration flyout

Expected behavior:

Screenshots (if relevant):

https://github.com/elastic/kibana/assets/7893459/c549424b-84fc-415c-b8eb-2df9051ac513

elasticmachine commented 2 months ago

Pinging @elastic/kibana-presentation (Team:Presentation)

cqliu1 commented 1 month ago

This should come after https://github.com/elastic/kibana/issues/151233 is merged. We may also want to consider disabling all of the actions besides maximize/minimize.

@andreadelrio What do you think?

andreadelrio commented 1 month ago

This should come after #151233 is merged. We may also want to consider disabling all of the actions besides maximize/minimize.

@andreadelrio What do you think?

@cqliu1 I'm thinking we implement something like this

CleanShot 2024-07-25 at 15 03 07

Where the maximize/minimize actions are the only actions available in the panel and they're visible at all times (so not a hover action). This pattern is the same that I'm proposing for the upcoming inline markdown editor (see https://github.com/elastic/kibana/issues/188910)

vikasrajputin commented 2 weeks ago

Hello @andreadelrio - Can i pick this?

Heenawter commented 2 weeks ago

@vikasrajputin Thanks so much! This is currently blocked until https://github.com/elastic/kibana/issues/151233 is resolved, but it will be unblocked soon :)