elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.7k stars 8.12k forks source link

[Security Solution] Implement `concurrent_searches` and `items_per_search` fields diff algorithms #188061

Closed jpdjere closed 4 hours ago

jpdjere commented 2 months ago

Epics: https://github.com/elastic/security-team/issues/1974 (internal), https://github.com/elastic/kibana/issues/174168

Summary

Implement algorithms for diffing and merging changes in concurrent_searches and items_per_search fields

These two fields require a specialized algorithm because of the following reasons:

Context from the Rule Customization RFC:

To do

elasticmachine commented 2 months ago

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine commented 2 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 2 months ago

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

banderror commented 2 months ago

@jpdjere Thanks for creating this ticket. One small reminder, please: every ticket in the backlog should have custom fields filled in, because that's what powers all our tabs in the GH project. I moved it to Inbox for now, but feel free to fill them in and move back to Backlog

Screenshot 2024-07-11 at 11 22 29
yctercero commented 1 month ago

@jpdjere is this work still required if we feel these fields should be deprecated? I guess even if they are we'll need to support past versions having it.

dplumlee commented 1 month ago

I think this work would be needed no matter what, but what might be a better way forward is to delete the fields from the DiffableRule type and instead just always use the current version as we don't seem to push updates to these fields anyways since they're performance based. This will forgo any elastic specific updates but will just automatically keep the user customized fields if they have changed them.

Right now, I'm not sure we'd need a diff algorithm for it as we will never return the fields in the eyes of the users anyways

dplumlee commented 4 hours ago

Closed by #190440