elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.63k stars 8.22k forks source link

Fix "@ts-expect-error upgrade typescript v5.1.6" in Security AET code #188668

Open semd opened 3 months ago

semd commented 3 months ago

https://github.com/elastic/kibana/pull/186437 upgrades upgrade typescript into v5.1.6

In order to make assumptions over the codebase and all the type of errors I choose to mark the failures with @ts-expect-error and let each team decide how to handle it. There is a list below with the files (and teams those belong to) where the annotations were added. If each team could provide help of fixing the ones under their domain it would be fantastic. It can be done in this PR or in subsequent ones.

Below are list of @ts-expect-error upgrade typescript v5.1.6 that need to be resolved once https://github.com/elastic/kibana/pull/186437 is merged

@elastic/security-solution

@elastic/security-threat-hunting-investigations

### Tasks
- [ ] https://github.com/elastic/kibana/issues/188815
elasticmachine commented 3 months ago

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

elasticmachine commented 3 months ago

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

elasticmachine commented 3 months ago

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

jaredburgettelastic commented 3 months ago

Looks like fixing the Entity Analytics file was already taken care of by the original PR, instead of adding @ts-expect-error. As it was a test file, and the change was just to some mocked data, no followup items needed on the part of @elastic/security-entity-analytics.

Thanks for the heads up @semd and @michaelolo24 ! I've checked off that file as done above.