elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[Embeddable Rebuild] Keep panel title in sync with saved object title #188858

Open Heenawter opened 3 months ago

Heenawter commented 3 months ago

Describe the bug: With React embeddables, we are always serializing the panel title even if it is equal to the default panel title / saved object title.

Steps to reproduce:

  1. Add a by-reference Map embeddable to your dashboard - keep the default panel title.
  2. Edit that Map saved object's title
  3. Go back to the dashboard
  4. The Map panel still shows the original title and not the updated one 🔥

Expected behavior: When the panel title is not overwritten and it is equal to the default panel title, it should not be serialized.

Screenshots (if relevant):

https://github.com/user-attachments/assets/057f8417-9f0c-4098-9db8-ee27466b3ea1

elasticmachine commented 3 months ago

Pinging @elastic/kibana-presentation (Team:Presentation)