elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.24k forks source link

[Dashboard usability] Filters are lost when users open dashboards in a new tab #188914

Open teresaalvarezsoler opened 4 months ago

teresaalvarezsoler commented 4 months ago

Bug When a user opens a dashboard in a new tab from the List view or the Recently view list, the filter pills, controls and KQL query are lost.

Expected behaviour All the filter pills, query and control values should be present when opening the dashboard in a new tab (same as when opening the dashboard in the same tab).

Steps to reproduce it

New tabs problem:

  1. Open a dashboard in view mode and add a filter pill, query and select any value in controls
  2. Go to the list view or the recently list view and open the dashboard in a new tab Image Image
  3. The filter pill and query are gone and the control shows an error Image
elasticmachine commented 4 months ago

Pinging @elastic/kibana-presentation (Team:Presentation)

tsullivan commented 4 months ago

This sounds like an enhancement request. For the filter pills, the user has the option to pin these in order for them to persist. If this enhancement is implemented, it feels like the value of the pinning feature gets undermined.

teresaalvarezsoler commented 4 months ago

Splitting this issue in two: https://github.com/elastic/kibana/issues/189710

rshen91 commented 3 months ago

I can't replicate this on main... has this been fixed? @elastic/kibana-presentation

Heenawter commented 3 months ago

@rshen91 I am personally not able to recreate the controls error (was this an ad-hoc data view @teresaalvarezsoler?), but I am definitely able to recreate the filters/query/controls selections being lost:

https://github.com/user-attachments/assets/be928aca-0ac2-46d8-b37f-8a4551299550

I assume this is what we are trying to fix here? 🤔

teresaalvarezsoler commented 3 months ago

Yes, what @Heenawter shows in the video is what we are trying to solve @rshen91

rshen91 commented 2 months ago

@teresaalvarezsoler @Heenawter Just want to make sure i'm following - so the filters are not saved or pinned. We want to carry over the unsaved filter in a new tab right? Should we also have any unsaved changes (like to panels) be impacted and carry over into a new tab? Thanks!

Heenawter commented 2 months ago

We want to carry over the unsaved filter in a new tab right? Should we also have any unsaved changes (like to panels) be impacted and carry over into a new tab?

Correct, yes :) It should have the exact same behaviour as if you were opening the dashboard in the same tab.