elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.68k stars 8.23k forks source link

[Security Solution] - investigate stopping rendering all tabs in timeline #189874

Open PhilippeOberti opened 3 months ago

PhilippeOberti commented 3 months ago

Description

Over the last few months/years we've seen a lot of SDHs and issues related to the fact that timeline always renders all the tabs even when it's not open. As soon as the timeline bottom bar is present on a page, even if timeline modal isn't open, we're making calls to the server side to fetch whatever is in the timeline tabs.

The reason behind implementing this in the first place was to have the data already fetched by the time a user would open the timeline modal, hence making the UI much nice as it would avoid loading spinners and show the data immediately.

One of the downsides is we're making potentially many calls on many pages even tough the users never opens the timeline modal. Back in December 2023/January 2024, we had a pretty big issue related to the new-at-the-time ESQL tab that was happening because the tab was rendered despite not being visited.

This behavior combined with the fact that timeline is unmounted from and remounted to the DOM every time the user changes to a page that does and does not have timeline in it, makes this even more of a load on the server and UI.

Acceptance criteria

elasticmachine commented 3 months ago

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine commented 3 months ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 3 months ago

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)