search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[ResponseOps][Connectors] No secrets warning when importing Connectors using "request action on conflict" #190056

Open pmuellr opened 3 months ago

pmuellr commented 3 months ago

When importing a connector using the Import function in Stack Manager / Saved Objects, and selecting "Automatically overwrite conflicts", the user is presented with a message "connector as sensitive information that require updates". This is because imported connectors have no secrets associated with them, and aren't usable till they are set.

However, if you select "Request action on conflict" instead of "Automatically overwrite conflicts", that message WILL NOT be shown.

The message should be shown in both cases.

"Automatically overwrite conflicts" - expected:

image

"Request action on conflict" - unexpected, should have the warning the message above has:

image

elasticmachine commented 3 months ago

Pinging @elastic/response-ops (Team:ResponseOps)

TinaHeiligers commented 3 months ago

FYI: The Saved Objects Management plugin handles import/export with ImportModeControl: https://github.com/elastic/kibana/blob/0a01fdd591de9139c96097ac3980c523d439c6d3/src/plugins/saved_objects_management/public/management_section/objects_table/components/import_mode_control.tsx#L89-L100

and export in the export_modal

It might be worth digging through that too.