elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[Infra UI] Settings doesn't handle errors #190083

Open neptunian opened 3 months ago

neptunian commented 3 months ago

When selecting one of the settings registered using uiSettings, errors aren't handled if the request fails and instead a success message is shown and changes are not saved. In this case the user doesn't have the advanced settings privilege.

https://github.com/user-attachments/assets/211966f9-b19b-4a5a-9b58-dedb3db82ad6

Related:

elasticmachine commented 3 months ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

crespocarlos commented 2 months ago

@roshan-elastic we need to prioritize this

roshan-elastic commented 2 months ago

Cheers @crespocarlos - put it v high on the backlog

crespocarlos commented 2 months ago

I wonder if we should hide settings from advance settings in this case.

crespocarlos commented 2 months ago

APM handles the error, but I think we should display a better message

Image

Whatever we do here we should make sure it's consistent with APM

smith commented 2 months ago

Whatever we do here we should make sure it's consistent with APM

...and they both should be consistent with the global advanced settings page.

I wonder if we should hide settings from advance settings in this case.

It probably should disable them with a note, similar to when you use uiSettings.overrides in your kibana.yml:

CleanShot 2024-08-23 at 15 22 34@2x