[UII] Consider removing or refactoring agent count in confirmation modals

jen-huang commented 2 months ago

When we update settings objects, we display a count of affected policies and agents:

However this is not done all the time, for example updating proxy only shows a generic confirmation message without counts:

As relationships between policies and settings objects have gotten more complex (multiple agent policies, per integration outputs, space awareness), we should consider removing these granular counts in favor of a generic message to reduce the need for these deep lookups.

Alternatively, look into simplifying the logic and/or moving them server-side.

Original discussion: https://github.com/elastic/kibana/pull/189125#discussion_r1713870533

elasticmachine commented 2 months ago

Pinging @elastic/fleet (Team:Fleet)

jillguyonnet commented 2 months ago

This could potentially be a welcome simplification for confirmation modals triggered by bulk agent actions, as there are props passed down for that purpose only: https://github.com/elastic/kibana/blob/439c7fa84c45b3c632193ce0ffd16b437ea21e08/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/bulk_actions.tsx#L93-L96

nchaulet commented 2 months ago

If this can help to make this a priority this will allow to support a higher number of agent policies (fetching more than 1000 agent policies) make the UI extremely slow more than 2 minute to get the confirm message when updating a default output https://github.com/elastic/ingest-dev/issues/3343

elastic / kibana

[UII] Consider removing or refactoring agent count in confirmation modals #190432