search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.23k forks source link

[Dataset Quality]🐞 Redundant Breakdown field change events #190532

Open mohamedhamed-ahmed opened 3 months ago

mohamedhamed-ahmed commented 3 months ago

📖 Description

As part of Telemetry Enhancement implementation we are now firing EBT events when the breakdown field changes.

The problem is that this event is now fired on page reload as well as navigating back and forth from the page.

This increases the number of events fired per breakdown field even if it didn't actually change.

✅ Acceptance Criteria

The BreakdownFieldChanged event should only be fired when the field actually changes.

elasticmachine commented 3 months ago

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

mohamedhamed-ahmed commented 3 months ago

Question here is do we really need to fix this or is it fine to have the event fired everytime on navigation and page refresh? @gbamparop wdyt?

gbamparop commented 3 months ago

Page reloads still count as new EBT events for other areas too right?

mohamedhamed-ahmed commented 3 months ago

Page reloads still count as new EBT events for other areas too right?

Good Point, yes it does count for example in the flyout opened event.

achyutjhunjhunwala commented 3 months ago

We need to understand what to count here. With the current situation, let say you selected an ECS field in the breakdown, and then navigated to Logs Explorer and then came back, it will count as 2 times since it gets tracked on page load. Is this fine or not ?

mohamedhamed-ahmed commented 3 months ago

@achyutjhunjhunwala IMO it shouldn't be this way, not just for the breakdown field but for all events as well.

At the moment its firing on more event on refresh as well as back and forth navigation for breakdown field change and flyout opened as well.

The question is would this change the way we look at the numbers or not. IMO for the flyout opened event it might not affect it much, but for the breakdown field change event it could have an effect on the way we look at these telemetries in the future because they might be used for comparison between different fields usages.

gbamparop commented 3 months ago

Is there a way to break down the charts so we can look at the top fields used based on how many users select them instead of looking at absolute numbers of the EBT events? If so, this could be used with the current set up