Adjust serverless tests that got skipped after roles and spaces changes

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.71k stars 8.12k forks source link

Adjust serverless tests that got skipped after roles and spaces changes #190622

Open pheyos opened 1 month ago

pheyos commented 1 month ago

After custom roles and multiple spaces have been enabled in the serverless QA environment, we had to skip some tests in that area. These tests should be adjusted (fixed to the new behavior or removed if no longer needed) once these feature are enabled in all environments. Some additional details are in the PR description of #190599.

List of test files with skips for the Data Discovery team:

https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/functional/test_suites/common/management/data_views/serverless.ts

elasticmachine commented 1 month ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

lukeelmers commented 1 month ago

@davismcphee Just wanted to make sure you are aware of this one so it can be prioritized to avoid a lapse in serverless test coverage. Platform Security team can help answer any questions about the changes that caused these tests to fail.

davismcphee commented 3 weeks ago

@lukeelmers Thanks for the heads up! We'll coordinate with Security and Operations to figure out how to address it.

These tests should be adjusted (fixed to the new behavior or removed if no longer needed) once these feature are enabled in all environments.

@pheyos Do you know how we'll know when the features are enabled in all environments, and we can address the skipped test? From what I understand in #190599, it sounds like we'll soon support multiple spaces in Serverless. Our skipped test is checking that the space column in Data View Management is hidden in Serverless, so I think we just need to update it to check that it's visible instead.

pheyos commented 3 weeks ago

how we'll know when the features are enabled in all environments

@davismcphee I think it's best to coordinate with Platform Security as they will be driving the roll-out to the environments and as part of that update of the local test configuration.

Our skipped test is checking that the space column in Data View Management is hidden in Serverless, so I think we just need to update it to check that it's visible instead.

Yes, I think the when in single space mode suite needs to be adjusted a bit:

change suite title title as we're no longer in single space mode then
the hides spaces UI test in that suite should be something like shows spaces UI, as you mentioned

davismcphee commented 3 weeks ago

@pheyos Sounds good, thanks!

cc @elastic/kibana-security