elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

CSS Deprecation Issue for Team: appex-sharedux, Found in file: solution_nav.scss #190887

Closed petrklapka closed 4 weeks ago

petrklapka commented 1 month ago

DEPRECATION: Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in & {}.

The file below has one or more instances where CSS behavior will change unless the declaration is moved above the nested rule. Line numbers for the declaration along with the file and line numbers in which the nested rule appears are shown below.

More info: https://sass-lang.com/d/mixed-decls

kibana/packages/shared-ux/page/solution_nav/src/solution_nav.scss

   ┌──> kibana/packages/shared-ux/page/solution_nav/src/solution_nav.scss
16 │     display: flex;
   │     ^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
55 │ ┌   &[tabindex='0']:focus:focus-visible {
56 │ │     outline-style: auto; /* 2 */
57 │ │   }
   │ └─── nested rule
   ╵

   ┌──> kibana/packages/shared-ux/page/solution_nav/src/solution_nav.scss
17 │     flex-direction: column;
   │     ^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
55 │ ┌   &[tabindex='0']:focus:focus-visible {
56 │ │     outline-style: auto; /* 2 */
57 │ │   }
   │ └─── nested rule
   ╵
elasticmachine commented 1 month ago

Pinging @elastic/appex-sharedux (Team:SharedUX)