elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.71k stars 8.12k forks source link

CSS Deprecation Issue for Team: kibana-visualizations, Found in file: helpers.scss #190913

Open petrklapka opened 3 weeks ago

petrklapka commented 3 weeks ago

DEPRECATION: Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in & {}.

The file below has one or more instances where CSS behavior will change unless the declaration is moved above the nested rule. Line numbers for the declaration along with the file and line numbers in which the nested rule appears are shown below.

More info: https://sass-lang.com/d/mixed-decls

kibana/x-pack/plugins/lens/public/trigger_actions/open_lens_config/helpers.scss

   ┌──> kibana/x-pack/plugins/lens/public/trigger_actions/open_lens_config/helpers.scss
8  │     max-inline-size: $euiSizeXXL * 20;
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵

   ┌──> kibana/x-pack/plugins/lens/public/trigger_actions/open_lens_config/helpers.scss
9  │     min-inline-size: $euiSizeXXL * 8;
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵

   ┌──> kibana/x-pack/plugins/lens/public/trigger_actions/open_lens_config/helpers.scss
10 │     background: $euiColorLightestShade;
   │     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss
34 │ ┌           @media only screen and (min-width: $minSize) and (max-width: $maxSize) {
35 │ │             @content;
36 │ │           }
   │ └─── nested rule
   ╵
elasticmachine commented 3 weeks ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)