[ML] CSS Deprecation Issue for Team: ml-ui, Found in file: help_popover.scss

[petrklapka]

DEPRECATION: Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in & {}.

The file below has one or more instances where CSS behavior will change unless the declaration is moved above the nested rule. Line numbers for the declaration along with the file and line numbers in which the nested rule appears are shown below.

More info: https://sass-lang.com/d/mixed-decls

kibana/x-pack/plugins/ml/public/application/components/help_popover/help_popover.scss

   ┌──> kibana/x-pack/plugins/ml/public/application/components/help_popover/help_popover.scss
8  │     max-height: 40vh;
   │     ^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
55 │ ┌   &[tabindex='0']:focus:focus-visible {
56 │ │     outline-style: auto; /* 2 */
57 │ │   }
   │ └─── nested rule
   ╵

   ┌──> kibana/x-pack/plugins/ml/public/application/components/help_popover/help_popover.scss
9  │     padding: $euiSizeS;
   │     ^^^^^^^^^^^^^^^^^^ declaration
   ╵
   ┌──> kibana/node_modules/@elastic/eui/src/global_styling/mixins/_helpers.scss
55 │ ┌   &[tabindex='0']:focus:focus-visible {
56 │ │     outline-style: auto; /* 2 */
57 │ │   }
   │ └─── nested rule
   ╵

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[imran-yasin]

I wanted to work on this.

[peteharverson]

Thanks for the offer of help on this one @imran-yasin but @darnautov has just started working on this one.

[peteharverson]

Closing, fixed by #191913