search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.71k stars 8.13k forks source link

[ResponseOps][Grouping] Empty state is shown while first loading groups data #190954

Open umbopepato opened 4 weeks ago

umbopepato commented 4 weeks ago

The @kbn/grouping library shows an empty state while loading groups data, since the default number of groups is 0:

Image

This might be confusing for the user who might think that the grouping query gave no results. Can be seen in Security > Alerts with Group by active and in Observability > Alerts in @maryam-saeidi's PR.

DoD

We should show the empty state only when the groups have been loaded.

elasticmachine commented 4 weeks ago

Pinging @elastic/response-ops (Team:ResponseOps)

umbopepato commented 4 weeks ago

@logeekal if Security is ok with this I'll just make the empty state and loading view mutually exclusive, otherwise if you want to continue showing the empty state I can make this behavior externally configurable

logeekal commented 3 weeks ago

Thanks @umbopepato for raising and fixing this. I 100% agree that both views should be mutually exclusive with a default placeholder components.

Additionally, good to have is to have configurable components for both of the states in case solutions do not want default placeholders.