search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.24k forks source link

[Onboarding] UI flickering when onboarding the CSPM integration #191741

Closed acorretti closed 2 months ago

acorretti commented 3 months ago

Summary

See the video from @oren-zohar, when onboarding the CSPM integration there are multiple items flickering on screen. Amongst them, a red alert message.

https://github.com/user-attachments/assets/83eddc4d-4874-4a13-970c-9b54e7260537

elasticmachine commented 3 months ago

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

JordanSh commented 3 months ago

Assigned myself and since the fix was really simple i added it as part of [Cloud Security] Support for missing fields in vulnerabilities and removing integration installation block #191504

Omolola-Akinleye commented 2 months ago

Subscription still flickers on Edit CSPM Integration Page

https://github.com/user-attachments/assets/28ebb92f-cf09-463e-b208-6b350908f53f

JordanSh commented 2 months ago

@Omolola-Akinleye can you confirm your env was running with https://github.com/elastic/kibana/pull/191504? i've checked it locally on main with slow 3G and the issue does not occur.

edit: I took a look and your test env did not include the fix, it was probably merged too late and did not update on serverless. I'm closing for now, let me know if i missed something and we need to reopen

Omolola-Akinleye commented 2 months ago

@JordanSh Ahhh okay good point! I will wait to test tomorrow.

Omolola-Akinleye commented 2 months ago

Verified Subscription license flicker doesn't occur Edit Integration

https://github.com/user-attachments/assets/94421199-97be-4619-82e5-f5cea3bf48f1

kubasobon commented 1 month ago

Don't know if it counts, but the Integration not verified callout still pops up for a split second when refreshing without cache / force reloading.

https://github.com/user-attachments/assets/2b321db7-6611-4394-bdf7-2a8cfbf3c119

opauloh commented 1 month ago

Don't know if it counts, but the Integration not verified callout still pops up for a split second when refreshing without cache / force reloading.

Screen.Recording.2024-10-25.at.15.25.39.mov

The original issue was actually pointing to the flickering on the Add CSPM page, the page that loads once we click on the "Add Cloud Security Posture (CSPM)" button, as that UI is developed and maintained by our team.

Image

The integration overview page is fully managed by the Fleet team, I think reporting the issue you found to the Fleet team would be great!

seanrathier commented 1 month ago

Don't know if it counts, but the Integration not verified callout still pops up for a split second when refreshing without cache / force reloading.

Screen.Recording.2024-10-25.at.15.25.39.mov

Good eye, it counts. However, we should create a different bug for this. This may be a race condition where we are showing the default view, before we receive the data that hides it.

This bug is related to the popcorn effect when the page is loading the SPM or CSPM integration customizations.