Document viewer disappears and reappears when ES|QL query is re-run

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.73k stars 8.14k forks source link

Document viewer disappears and reappears when ES|QL query is re-run #191885

Open smith opened 3 weeks ago

smith commented 3 weeks ago

Describe the bug:

Using cmd-enter to re-run the query in ES|QL hides then shows the document viewer. This does not happen using KQL.

Steps to reproduce:

Query ES|QL data in DIscover
Open a document viewer flyout
Go back to the ES|QL text area
cmd-enter or click refresh/run button
The document viewer disappears then reappears

Expected behavior:

The query is re-run and the document viewer does not disappear and reappear but stays where it is.

Screenshots (if relevant):

elasticmachine commented 3 weeks ago

Pinging @elastic/kibana-esql (Team:ESQL)

elasticmachine commented 3 weeks ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

stratoula commented 2 weeks ago

I am changing this to enhancement because although it feels weird I think is because running the query re-renders many components in Discover and I am not expecting to be easy to improve.

Unless I am wrong of course, the @elastic/kibana-data-discovery knows better and can evaluate.

kertal commented 2 weeks ago

I am changing this to enhancement because although it feels weird I think is because running the query re-renders many components in Discover and I am not expecting to be easy to improve.

Unless I am wrong of course, the @elastic/kibana-data-discovery knows better and can evaluate.

Yes, it ain't a bug in the code, it always worked like this. But I do agree that it would enhance UX if it would work differently, so it wouldn not disappear. And it seems @davismcphee already is experimenting with it https://github.com/elastic/kibana/pull/191695

stratoula commented 2 weeks ago

Awesome 🙌

davismcphee commented 2 weeks ago

Yup I started looking at this a bit last week when I noticed the Slack thread, but didn't get to a solution yet. Now that an issue exists, I linked the PR.