elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.62k stars 8.22k forks source link

[Inventory] Use `observability:entityCentricExperience` to enable inventory #192323

Closed smith closed 1 month ago

smith commented 2 months ago

In https://github.com/elastic/kibana/pull/191798 the visibility of the inventory navigation is controlled by the kibana.yml setting xpack.inventory.enabled. It should use the observability:entityCentricExperience advanced setting instead.

✔ Acceptance critieria

xpack.inventory.enabled does not exist (it can be removed without deprecation since it was never used by customers)
When the observability:entityCentricExperience advanced setting is enabled I can see and use the top-level inventory navigation.

elasticmachine commented 2 months ago

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

iblancof commented 1 month ago

@smith are we sure we want to enable this with the observability:entityCentricExperience advanced setting instead of using the xpack.inventory.enabled flag in thekibana.yml before all the development is finished?

This issue was in the "Ready" column, and I started working on it, but this question came to mind.

cc:@roshan-elastic, @cauemarcondes, @kpatticha

smith commented 1 month ago

@smith are we sure we want to enable this with the observability:entityCentricExperience advanced setting instead of using the xpack.inventory.enabled flag in thekibana.yml before all the development is finished?

Yes. The difference between the two is:

kibana.yml items have to be on the allow list to be available on cloud or serverless
kibana.yml changes require a restart of the kibana node process
Advanced settings can be enabled per space (in the UI) or per kibana instance (with overrides in Kibana.yml)

If the advanced setting is enabled and a user sees technical preview software on serverless that is not finished it is not a problem.

The next release feature freeze is October 15 and at that time things will be in a much less unfinished state.

iblancof commented 1 month ago

If the advanced setting is enabled and a user sees technical preview software on serverless that is not finished it is not a problem.

This is the answer I was looking for, thanks @smith!!

kpatticha commented 1 month ago

@iblancof feel free to raise any questions or concerns, even if the ticket is in the "Ready" state.