elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.61k stars 8.22k forks source link

[Lens] Integrate Borealis color palette #192848

Open teresaalvarezsoler opened 1 month ago

teresaalvarezsoler commented 1 month ago

Description

The new Borealis color palette needs to be tested for all chart types to make sure they both work well for all edge cases.

Tasks

Testing

Test the following scenarios:

elasticmachine commented 1 month ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

florent-leborgne commented 1 month ago

Hi! Here are some naming suggestions for the new, and current, color palettes:

the 2 new palettes

the existing ones

The new ones don't get any temporality in the way they're named, to reinforce that they're the current best and latest. The older ones get renamed to add that temporality notion so that users know they're what they've seen/used in the past, in case they get nostalgic of the old days.

Let me know what you think and we can refine as needed.

nickofthyme commented 1 month ago

@gvnmagni in the meeting this week it was mentioned to use prefers-contrast. To me that would mean we have a user setting toggle, then we use this under the hood to pick the high contrast color palette based on the selected palette. Assuming not all palettes have a high contrast version, I don't know how/if we want to alert the user when the current palette does not support high contrast.

In this flow there would be no need for the explicit naming of the Elastic high contrast palette.

gvnmagni commented 1 month ago

This is a good point, technically this setting would be available only if the user selected the new color palette as a default because, as you correctly pointed out, there is no alternative for other palettes.

Would this setting be disabled if the user didn't choose to move to the new palette? How do you see something like that, can we do it?