search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

[Discover] Improve flyout interaction #193452

Open ryankeairns opened 5 hours ago

ryankeairns commented 5 hours ago

In addition to the aforementioned issue with the multiple flyouts, I don't think we want to ship with this scenario either (resizing with docs flyout in between) :/

Below, you'll see how resizing the doc viewer gets pretty funky if/when the inline docs panel is sandwiched in between.

CleanShot 2024-09-18 at 15 02 35

Originally posted by @ryankeairns in https://github.com/elastic/kibana/issues/192156#issuecomment-2359486565

This behavior existed prior to the referenced ES|QL docs PR. See this comment below where it happens with the 'Edit viz' flyout

https://github.com/elastic/kibana/pull/192156#issuecomment-2360125234

meow

@davismcphee provided some additional context:

Responded to @ryankeairns directly in Slack, but adding here too. If the ES|QL editor provides an onOpenDocsFlyout callback and some handle we can use to dismiss the flyout, e.g. through a React ref, we should be able to close the doc viewer when the docs flyout is opened and vice versa. We do similar for dismissing the doc viewer elsewhere in Discover already.

elasticmachine commented 5 hours ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)