[Stateful o11y nav] Machine learning group does not appear in the o11y side nav

[mgiota]

🍒 Summary

As mentioned here, the Machine Learning group disappeared from the o11y stateful side navigation. It turns out that this PR automatically disabled the security plugin, and in consequence the ML landing page is not accessible from the o11y plugin. As it is not available, the side nav automatically removed the whole “Machine learning” group.

Proposal

1. we should move that landing page inside the maching learning plugin (x-pack/ml) and
2. declare the deeplink in the ml plugin (not security)

cc @sebelga @semd

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[semd]

Hey @mgiota, that seems reasonable.

I wonder what this means:

declare the deeplink in the ml plugin (not security)

Aren't all ML deepLinks declared at packages/deeplinks/ml/deep_links.ts

Some technical considerations

Right now all our landing pages are rendered using the _landing_links_ reusable components from the security navigation package.

This ML landing page will be the first one we render outside security, it would be good if we all keep using the same reusable components to ensure consistency across Kibana. However, these components are still under the security package, it would be ideal to extract them to a generic place before using them in other plugins (only the landing_links components, not the entire navigation package). I think they should be pretty easy to move to a generic package, we tried to design them as pure components, as decoupled as possible, so there should not be many security-specific assumptions in there, but feel free to ping @elastic/security-threat-hunting-explore for any doubt/question.

Reminder: links that are not enabled in the navLinks (registered deepLinks) should be filtered out before passing them to the landing components.

Implications for Security (cc @paulewing)

I think it is worth mentioning that by moving the landing page to the ML plugin, Security will lose control over the links displayed on the ML landing page. We are not going to be able to add or remove solution-specific stuff. I am not saying this is a problem, I just want to make sure we are all on board with this strategy. Another approach could be that all solutions create all landing pages inside their own plugins and URLs, using the same reusable components from the package (once extracted).

[arisonl]

In order to make sure we avoid any stakeholder being surprised, I am re-iterating here the expected state of the solutions-specific menu in 8.16 stateful, as it has been discussed between platform and solutions product leads:

• Security and Observability will have the vanilla ML menu, i.e. the full stateful ML menu without omissions/additions.
• ML management-related functionality will be available from the management menu in all solutions. This includes:
  • The ML management view (/app/management/insightsAndAlerting/jobsListLink) through which users manage jobs, models etc. across spaces.
  • The ability to create Anomaly detection and anomaly detection health rules from within Stack management.

Please let me and @kevinsweet know of any issues/concerns. cc @paulewing