elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

[Dashboard] embeddable filters are not displayed #193553

Closed mbondyra closed 12 minutes ago

mbondyra commented 3 hours ago

Kibana version: main

While working on https://github.com/elastic/kibana/pull/186642 we noticed that the filter icon doesn't display correctly for Lens embeddable. After digging more, it looks like the problem appears for all the embeddables.

expected display

Image

actual display (when loaded for the first time)

Image

(For Lens, it works on main because it hasn't been rewritten yet, but looks like the root cause might be the same as for visualize.

As for Maps, it works correctly, but once you click on the options for "maps by reference + filters" map vis, and Edit map, the filter is lost (video documenting it below)

https://github.com/user-attachments/assets/1a307b33-bc1c-4f8c-b122-b90b5139b773

Also, side question - did we remove the 'linked to library' icon (see the expected display) or is this a bug too that it doesn't display? 🤔

To reproduce you can use the SOs from here. Change the extension to .ndjson: filtersbug.json

elasticmachine commented 3 hours ago

Pinging @elastic/kibana-presentation (Team:Presentation)

teresaalvarezsoler commented 2 hours ago

Afaik, the Saved to library icon should appear too. I think we will remove it as part of this other PR but it hasn't been merged yet https://github.com/elastic/kibana/pull/182535. Can you please confirm @andreadelrio?

nreese commented 50 minutes ago

Afaik, the Saved to library icon should appear too. I think we will remove it as part of this other PR but it hasn't been merged yet https://github.com/elastic/kibana/pull/182535.

Library notification was removed outside of hover actions in https://github.com/elastic/kibana/pull/190797.

nreese commented 12 minutes ago

This issue covers a few items. I am going to close and break items out into separate issues.

Created https://github.com/elastic/kibana/issues/193598 for visualize embeddable not displaying filters notification.